Skip to content

Mmap windows #15538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 4, 2025
Merged

Mmap windows #15538

merged 8 commits into from
Nov 4, 2025

Conversation

@JacobSzwejbka
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka commented Nov 3, 2025

Current windows implementation had issues with 64 bit files. This expands the coverage to work properly and add some tests

@JacobSzwejbka JacobSzwejbka requested a review from lucylq as a code owner November 3, 2025 23:19
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15538

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 8d2761a with merge base 8c92793 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync
Copy link

meta-codesync bot commented Nov 3, 2025

@JacobSzwejbka has imported this pull request. If you are a Meta employee, you can view this in D86144946.

lucylq
lucylq reviewed Nov 4, 2025
View reviewed changes
extension/data_loader/mman.h
/**
* Platform-specific file stat function.
*/
ET_INLINE int get_file_stat(int fd, size_t* out_size) {
Copy link
Contributor

@lucylq lucylq Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, having out_size as a size_t* should not pose an issue as we wouldn't be able to map >4gb on 32bit system anyways, right?

Copy link
Contributor Author

@JacobSzwejbka JacobSzwejbka Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

lucylq
lucylq approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@lucylq lucylq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the test!

cc @SS-JIA for windows changes as well.

@JacobSzwejbka JacobSzwejbka merged commit e3b7eda into main Nov 4, 2025
150 of 152 checks passed
@JacobSzwejbka JacobSzwejbka deleted the mmap-windows branch November 4, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucylq lucylq lucylq approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JacobSzwejbka @lucylq